Page MenuHomeSoftware Heritage

Use unbound methods as callbacks for confluent-kafka.
ClosedPublic

Authored by vlorentz on Wed, Oct 30, 11:50 AM.

Details

Summary

Using bound methods causes consumer.poll() to return None under some
(apparently deterministic but unclear) conditions.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Wed, Oct 30, 11:50 AM
vlorentz updated this revision to Diff 7499.Wed, Oct 30, 11:53 AM

remove old methods

Tests are broken because swh-storage needs a release (ping @douardda )

olasd accepted this revision.Wed, Oct 30, 11:59 AM
This revision is now accepted and ready to land.Wed, Oct 30, 11:59 AM
This revision was landed with ongoing or failed builds.Wed, Oct 30, 12:13 PM
This revision was automatically updated to reflect the committed changes.