Differential D2199

Use unbound methods as callbacks for confluent-kafka.
ClosedPublic
Actions

Authored by vlorentz on Oct 30 2019, 11:50 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDJNL98c58572f32f: Use unbound methods as callbacks for confluent-kafka.

Summary

Using bound methods causes consumer.poll() to return None under some
(apparently deterministic but unclear) conditions.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 30 2019, 11:50 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 30 2019, 11:50 AM

remove old methods

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/292/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/292/console

Harbormaster failed remote builds in B8704: Diff 7498!Oct 30 2019, 11:54 AM

Tests are broken because swh-storage needs a release (ping @douardda )

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/293/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/293/console

Harbormaster failed remote builds in B8705: Diff 7499!Oct 30 2019, 11:57 AM

olasd accepted this revision.Oct 30 2019, 11:59 AM

This revision is now accepted and ready to land.Oct 30 2019, 11:59 AM

This revision was landed with ongoing or failed builds.Oct 30 2019, 12:13 PM

Closed by commit rDJNL98c58572f32f: Use unbound methods as callbacks for confluent-kafka. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDJNL98c58572f32f: Use unbound methods as callbacks for confluent-kafka..

vlorentz mentioned this in T2034: Unbreak journal clients.Nov 4 2019, 12:22 PM

Revision Contents
Changeset List

Path

Size

swh/

journal/

client.py

24 lines

Diff 7501

View Options

Use unbound methods as callbacks for confluent-kafka.ClosedPublicActions