Paths

Table of Contentst

Differential D2196

[PoC] Use swh-search instead of swh-storage for searching origins.
AbandonedPublic
Actions

Authored by vlorentz on Oct 29 2019, 5:16 PM.

Tags

None

Subscribers

Details

Reviewers

None

Group Reviewers

Diff Detail

Repository

rDWAPPS Web applications

Branch

swh-search

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9394
Build 13758: Cypress tests for swh-web diffs	Jenkins
Build 13757: tox-on-jenkins	Jenkins
Build 13756: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 29 2019, 5:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2019, 5:16 PM

vlorentz retitled this revision from Use swh-search instead of swh-storage for searching origins. to [PoC] Use swh-search instead of swh-storage for searching origins..Oct 29 2019, 5:17 PM

Harbormaster failed remote builds in B8690: Diff 7484!Oct 29 2019, 5:17 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/747/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/747/console

(Tests fail because of T2052)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/349/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/349/console

sounds good.

The build seems to fail because of patch appliance failure.

swh/web/tests/data.py
250	} for
321	should be renamed to something more storage independent. It overrides internal api services the webapp relies on. Might be `override_api_services` or something. Also, i'd be surprised this is used for production code. Couldn't this be a pytest fixture only?

anlambert added a subscriber: anlambert.Nov 20 2019, 11:02 AM

anlambert added inline comments.

swh/web/tests/data.py
321	It overrides internal api services the webapp relies on. No, it really overrides storage and search components by their in-memory implementation. Maybe adding a dedicated function to override the search engine would be better here. Couldn't this be a pytest fixture only? Pytest fixtures using these in-memory storages under the hood have landed in master. This diff has not been rebased against it yet.

vlorentz planned changes to this revision.Nov 21 2019, 11:25 AM

rebase

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/789/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/789/console

Harbormaster failed remote builds in B9281: Diff 8023!Nov 21 2019, 4:16 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/388/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/388/console

rename 'scroll_token' to 'page_token', required by swh.search 0.0.3.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/801/ for more details.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/400/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/400/console

Harbormaster failed remote builds in B9394: Diff 8323!Nov 27 2019, 2:28 PM

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/829/ for more details.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/427/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/427/console

Harbormaster failed remote builds in B9499: Diff 8423!Dec 3 2019, 4:43 PM

fix tests

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/830/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/428/ for more details.

Harbormaster completed remote builds in B9500: Diff 8424.Dec 3 2019, 5:31 PM

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/845/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/442/ for more details.

Harbormaster completed remote builds in B9666: Diff 8585.Dec 10 2019, 6:34 PM

rebase

vlorentz planned changes to this revision.Jan 7 2020, 2:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/863/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/470/ for more details.

Harbormaster completed remote builds in B9989: Diff 8890.Jan 7 2020, 2:29 PM

rebase

vlorentz planned changes to this revision.Jan 7 2020, 3:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/867/ for more details.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/474/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/474/console

Harbormaster failed remote builds in B9995: Diff 8896!Jan 7 2020, 3:22 PM

vlorentz mentioned this in D2501: Add support for using swh-search for URL search..Jan 7 2020, 3:50 PM

Replaced by D2501

Revision Contents
Changeset List

Path

Size

requirements-swh.txt

1 line

swh/

web/

api/

views/

20 lines

browse/

views/

8 lines

common/

12 lines

16 lines

settings/

3 lines

tests/

api/

views/

20 lines

3 lines

19 lines

Diff 8323

requirements-swh.txt

Loading...

swh/web/api/views/origin.py

Loading...

swh/web/browse/views/origin.py

Loading...

swh/web/common/service.py

Loading...

swh/web/config.py

Loading...

swh/web/settings/tests.py

Loading...

swh/web/tests/api/views/test_origin.py

Loading...

swh/web/tests/conftest.py

Loading...

swh/web/tests/data.py

Loading...