Page MenuHomeSoftware Heritage

[PoC] Use swh-search instead of swh-storage for searching origins.
AbandonedPublic

Authored by vlorentz on Oct 29 2019, 5:16 PM.

Details

Reviewers
None
Group Reviewers
Reviewers

Diff Detail

Event Timeline

vlorentz created this revision.Oct 29 2019, 5:16 PM
vlorentz retitled this revision from Use swh-search instead of swh-storage for searching origins. to [PoC] Use swh-search instead of swh-storage for searching origins..Oct 29 2019, 5:17 PM

(Tests fail because of T2052)

sounds good.

The build seems to fail because of patch appliance failure.

swh/web/tests/data.py
257

} for

322

should be renamed to something more storage independent.
It overrides internal api services the webapp relies on.
Might be override_api_services or something.


Also, i'd be surprised this is used for production code.
Couldn't this be a pytest fixture only?

anlambert added inline comments.
swh/web/tests/data.py
322

It overrides internal api services the webapp relies on.

No, it really overrides storage and search components by their in-memory implementation.
Maybe adding a dedicated function to override the search engine would be better here.

Couldn't this be a pytest fixture only?

Pytest fixtures using these in-memory storages under the hood have landed in master.
This diff has not been rebased against it yet.

vlorentz planned changes to this revision.Nov 21 2019, 11:25 AM
vlorentz updated this revision to Diff 8323.Nov 27 2019, 2:17 PM

rename 'scroll_token' to 'page_token', required by swh.search 0.0.3.

vlorentz updated this revision to Diff 8424.Dec 3 2019, 5:18 PM

fix tests

vlorentz planned changes to this revision.Jan 7 2020, 2:18 PM
vlorentz planned changes to this revision.Jan 7 2020, 3:10 PM
vlorentz abandoned this revision.Jan 9 2020, 3:46 PM

Replaced by D2501