Page MenuHomeSoftware Heritage

typing: minimal changes to make a no-op mypy run pass
ClosedPublic

Authored by zack on Oct 15 2019, 3:59 PM.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack planned changes to this revision.Oct 15 2019, 3:59 PM

doesn't actually pass mypy yet, will update

Updating D2144: [WIP] typing: minimal changes to make a no-op mypy run pass

zack retitled this revision from [WIP] typing: minimal changes to make a no-op mypy run pass to typing: minimal changes to make a no-op mypy run pass.Oct 20 2019, 9:08 AM
zack added a reviewer: vlorentz.
  • storage/db.py: drop unused format arg regconfig from query

Could you replace cast(GemspecMapping, MAPPINGS['GemspecMapping']) (and others) with an import of GemspecMapping from swh.indexer.metadata_dictionary.ruby?

This revision now requires changes to proceed.Oct 29 2019, 12:01 PM
  • test_metadata typing: use type-specific mappings instead of cast

Could you replace cast(GemspecMapping, MAPPINGS['GemspecMapping']) (and others) with an import of GemspecMapping from swh.indexer.metadata_dictionary.ruby?

Done now.

This revision is now accepted and ready to land.Oct 29 2019, 3:22 PM