⚙ D2144 typing: minimal changes to make a no-op mypy run pass

zack created this revision.Oct 15 2019, 3:59 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 15 2019, 3:59 PM

doesn't actually pass mypy yet, will update

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/631/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/631/console

Harbormaster failed remote builds in B8471: Diff 7255!Oct 15 2019, 4:01 PM

Updating D2144: [WIP] typing: minimal changes to make a no-op mypy run pass

zack retitled this revision from [WIP] typing: minimal changes to make a no-op mypy run pass to typing: minimal changes to make a no-op mypy run pass.Oct 20 2019, 9:08 AM

zack added a reviewer: vlorentz.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/632/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/632/console

Harbormaster failed remote builds in B8559: Diff 7360!Oct 20 2019, 9:10 AM

storage/db.py: drop unused format arg regconfig from query

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/633/ for more details.

Harbormaster completed remote builds in B8560: Diff 7361.Oct 20 2019, 9:18 AM

Could you replace cast(GemspecMapping, MAPPINGS['GemspecMapping']) (and others) with an import of GemspecMapping from swh.indexer.metadata_dictionary.ruby?

vlorentz requested changes to this revision.Oct 29 2019, 12:01 PM

This revision now requires changes to proceed.Oct 29 2019, 12:01 PM

test_metadata typing: use type-specific mappings instead of cast

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/634/ for more details.

Harbormaster completed remote builds in B8677: Diff 7471.Oct 29 2019, 3:03 PM

In D2144#51338, @vlorentz wrote:

Could you replace cast(GemspecMapping, MAPPINGS['GemspecMapping']) (and others) with an import of GemspecMapping from swh.indexer.metadata_dictionary.ruby?

Done now.

vlorentz accepted this revision.Oct 29 2019, 3:22 PM

This revision is now accepted and ready to land.Oct 29 2019, 3:22 PM

Closed by commit rDCIDXb8562b11eca1: typing: minimal changes to make a no-op mypy run pass (authored by zack). · Explain WhyOct 29 2019, 4:40 PM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDCIDXb8562b11eca1: typing: minimal changes to make a no-op mypy run pass.

zack added a commit: rDCIDX36ec832a9643: storage/db.py: drop unused format arg regconfig from query.

zack added a commit: rDCIDX35296e8044a3: test_metadata typing: use type-specific mappings instead of cast.

typing: minimal changes to make a no-op mypy run pass
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 7360

.gitignore

MANIFEST.in

mypy.ini

swh/init.py

swh/indexer/cli.py

swh/indexer/fossology_license.py

swh/indexer/indexer.py

swh/indexer/metadata_dictionary/base.py

swh/indexer/mimetype.py

swh/indexer/py.typed

swh/indexer/tests/conftest.py

swh/indexer/tests/storage/test_storage.py

swh/indexer/tests/test_fossology_license.py

swh/indexer/tests/test_metadata.py

swh/indexer/tests/test_mimetype.py

swh/indexer/tests/utils.py

tox.ini

typing: minimal changes to make a no-op mypy run passClosedPublicActions