Page MenuHomeSoftware Heritage
Differential D2137

schemata: Send only origin url for scheduling debian loader tasks
ClosedPublic
Actions

Authored by ardumont on Oct 14 2019, 3:06 PM.

Details

Reviewers
olasd
douardda
vlorentz
Group Reviewers
Reviewers
Commits
rDSTOC484cebb2c34f: schemata: Send only origin url for scheduling debian loader task
rDSTO484cebb2c34f: schemata: Send only origin url for scheduling debian loader task
Summary

This answers the part mentioned in the new loader-debian implementation diff:

About debian lister, in any case:

  • We'll need to adapt slightly the lister to pass solely the origin url and not the origin dict

Related D2135
Related T2025

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 14 2019, 3:06 PM
swh-public-ci added a comment.Oct 14 2019, 3:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/737/ for more details.

Harbormaster completed remote builds in B8431: Diff 7215.Oct 14 2019, 3:14 PM
ardumont updated this revision to Diff 7226.Oct 14 2019, 3:14 PM

Rebase on latest master

swh-public-ci added a comment.Oct 14 2019, 3:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/738/ for more details.

Harbormaster completed remote builds in B8442: Diff 7226.Oct 14 2019, 3:18 PM
ardumont mentioned this in D2138: loader.debian: Send only the origin url instead of the origin dict.Oct 14 2019, 3:39 PM
ardumont edited the summary of this revision. (Show Details)Oct 14 2019, 3:40 PM
ardumont edited the summary of this revision. (Show Details)Oct 14 2019, 3:42 PM
ardumont edited the summary of this revision. (Show Details)Oct 14 2019, 3:45 PM
ardumont mentioned this in D2135: package.debian: Re-implement debian loader within the package loader mechanism.Oct 15 2019, 1:10 PM
ardumont updated this revision to Diff 7304.Oct 17 2019, 1:45 PM

Rebase to latest master

swh-public-ci added a comment.Oct 17 2019, 1:49 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/739/ for more details.

Harbormaster completed remote builds in B8502: Diff 7304.Oct 17 2019, 1:49 PM
vlorentz requested changes to this revision.Oct 17 2019, 3:13 PM
vlorentz added a subscriber: vlorentz.

Could you add a test?

This revision now requires changes to proceed.Oct 17 2019, 3:13 PM
ardumont added a comment.EditedOct 17 2019, 3:18 PM

Could you add a test?

Well, no,

  1. there is no test at all.
  1. And this will go deprecated as soon as we land the package loader (soon).
  1. That package loader includes the new debian loader (D2135, which is tested).

That does not use this schemata model any more.

The debian lister will have that model part moved there (already tested).

And that part of the code will be dropped... and currently reinjected where it belong within the lister as the other listers do.

It really feels unnecessary...

ardumont mentioned this in rDLDDEB018ee8d39cfa: loader.debian: Send only the origin url instead of the origin dict.Oct 17 2019, 3:19 PM
vlorentz accepted this revision.Oct 17 2019, 3:29 PM
This revision is now accepted and ready to land.Oct 17 2019, 3:29 PM
ardumont updated this revision to Diff 7325.Oct 17 2019, 5:54 PM

Rebase to latest master

swh-public-ci added a comment.Oct 17 2019, 5:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/747/ for more details.

Harbormaster completed remote builds in B8524: Diff 7325.Oct 17 2019, 5:58 PM
ardumont updated this revision to Diff 7326.Oct 17 2019, 6:01 PM

Plug to master branch

swh-public-ci added a comment.Oct 17 2019, 6:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/748/ for more details.

Harbormaster completed remote builds in B8525: Diff 7326.Oct 17 2019, 6:05 PM
Closed by commit rDSTO484cebb2c34f: schemata: Send only origin url for scheduling debian loader task (authored by ardumont). · Explain WhyOct 17 2019, 6:07 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDSTO484cebb2c34f: schemata: Send only origin url for scheduling debian loader task.
ardumont added a commit: rDSTOC484cebb2c34f: schemata: Send only origin url for scheduling debian loader task.Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
schemata/
2 lines

Diff 7328

View Options

swh/storage/schemata/distribution.py

Loading...
About · Developer information · Legal