jenkins-jobs: swh-tox: Allow job to build against remote branch (different than master)
AbandonedPublic
Actions

Authored by ardumont on Oct 13 2019, 6:10 PM.

Details

Reviewers

olasd
douardda
anlambert

Group Reviewers

Reviewers

Summary

Note:
Bluntly, I don't really know if:

ok
at the right location
enough
how to join the information I see in those files with the one we see in the ui... (to check my assertions)

What I know is that it seems to match with what I did manually in the diff job
(add a new build parameter BRANCH, defaulting to origin/master, remove the
checked "apply to master" setting) see the links below for more details.

And that build is now green.

Test Plan

tox

Diff Detail

Repository

rCJSWH Jenkins jobs

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 8384
Build 12141: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 13 2019, 6:10 PM

Harbormaster completed remote builds in B8384: Diff 7170.Oct 13 2019, 6:10 PM

ardumont retitled this revision from jenkins-jobs: swh-tox: Allow job to build against remote branch to jenkins-jobs: swh-tox: Allow job to build against remote branch (different than master).Oct 13 2019, 6:35 PM

ardumont mentioned this in D2142: package.debian: Use last snapshot to avoid re-loading a debian package.Oct 15 2019, 2:05 PM

I think only the part where you set apply-to-master: false to phabricator-differential makes a difference. I suppose that this makes arc patch checkout the base revision for the diff before running, therefore ignoring the actual branch the patch is applied against.

This means that you can at least drop the new BRANCH parameter (which isn't used anyway). I'm not sure if the removal of the branches parameter to scm.git is needed either (maybe it helps phabricator-differential have the base commit available)

Thanks for the heads up!

I'll have a look later though ;)

ardumont planned changes to this revision.Oct 18 2019, 7:05 PM

ardumont abandoned this revision.Feb 28 2020, 2:18 PM

Revision Contents
Changeset List

Path

Size

jobs/

templates/

swh-tox.yaml

9 lines

Diff 7170

View Options

jobs/templates/swh-tox.yaml

jenkins-jobs: swh-tox: Allow job to build against remote branch (different than master)AbandonedPublicActions