Paths

Table of Contentst

Differential D2017

writer: Normalize 'cls' value to 'memory' for in-memory instantiation
ClosedPublic
Actions

Authored by ardumont on Sep 20 2019, 1:47 PM.

Details

Reviewers

olasd
douardda
vlorentz

Group Reviewers

Reviewers

Commits

rDJNL64a0cbae0b05: writer: Normalize 'cls' value to 'memory' for in-memory instantiation

Summary

And keep the old key for backward compatibility.

Test Plan

tox

Note:
We no longer have any routine to setup kafka in the dev's machine.
I could not test fast enough the diff, i rely on the CI here.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 20 2019, 1:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/267/ for more details.

Harbormaster completed remote builds in B7890: Diff 6781.Sep 20 2019, 1:51 PM

What's wrong with inmemory?

Also, use this:

warnings.warn("cls = 'inmemory' is deprecated, use 'memory' instead", DeprecationWarning)

vlorentz requested changes to this revision.Sep 20 2019, 1:53 PM

This revision now requires changes to proceed.Sep 20 2019, 1:53 PM

What's wrong with inmemory?

Check indexer-storage and storage, it's 'memory' there.
Thus the normalize in the title ;)

Ack on the warning.
Will fix.

Add deprecation warning

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/268/ for more details.

Harbormaster completed remote builds in B7892: Diff 6783.Sep 20 2019, 2:41 PM

vlorentz accepted this revision.Sep 21 2019, 9:20 PM

This revision is now accepted and ready to land.Sep 21 2019, 9:20 PM

Closed by commit rDJNL64a0cbae0b05: writer: Normalize 'cls' value to 'memory' for in-memory instantiation (authored by ardumont). · Explain WhySep 22 2019, 9:35 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDJNL64a0cbae0b05: writer: Normalize 'cls' value to 'memory' for in-memory instantiation.

Revision Contents
Changeset List

Path

Size

swh/

journal/

writer/

__init__.py

7 lines

Diff 6796

View Options

swh/journal/writer/init.py

writer: Normalize 'cls' value to 'memory' for in-memory instantiationClosedPublicActions