Page MenuHomeSoftware Heritage

writer: Normalize 'cls' value to 'memory' for in-memory instantiation
ClosedPublic

Authored by ardumont on Fri, Sep 20, 1:47 PM.

Details

Summary

And keep the old key for backward compatibility.

Test Plan

tox

Note:
We no longer have any routine to setup kafka in the dev's machine.
I could not test fast enough the diff, i rely on the CI here.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Sep 20, 1:47 PM

What's wrong with inmemory?

Also, use this:

warnings.warn("cls = 'inmemory' is deprecated, use 'memory' instead", DeprecationWarning)
vlorentz requested changes to this revision.Fri, Sep 20, 1:53 PM
This revision now requires changes to proceed.Fri, Sep 20, 1:53 PM

What's wrong with inmemory?

Check indexer-storage and storage, it's 'memory' there.
Thus the normalize in the title ;)

Ack on the warning.
Will fix.

ardumont updated this revision to Diff 6783.Fri, Sep 20, 2:37 PM

Add deprecation warning

vlorentz accepted this revision.Sat, Sep 21, 9:20 PM
This revision is now accepted and ready to land.Sat, Sep 21, 9:20 PM