Page MenuHomeSoftware Heritage
Differential D1976

Convert 'transplant_source' extra header to bytehex
ClosedPublic
Actions

Authored by vlorentz on Sep 10 2019, 4:24 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDJNL6738d448de69: Convert 'transplant_source' extra header to bytehdex.
Summary

extra header values should always be bytes, and make swh-storage
crash if they are not.

Bug introduced in D1507.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 10 2019, 4:24 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2019, 4:24 PM
swh-public-ci added a comment.Sep 10 2019, 4:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/242/ for more details.

Harbormaster completed remote builds in B7750: Diff 6664.Sep 10 2019, 4:28 PM
anlambert mentioned this in D1977: Fix revision extra header value type.Sep 10 2019, 4:31 PM
vlorentz planned changes to this revision.Sep 10 2019, 4:58 PM

Looks like we're heading to bytehex digests instead of bytes digests

vlorentz updated this revision to Diff 6674.Sep 11 2019, 11:32 AM

use bytehex instead of bytes

vlorentz retitled this revision from Convert 'transplant_source' extra header to bytes. to Convert 'transplant_source' extra header to bytehex.Sep 11 2019, 11:32 AM
swh-public-ci added a comment.Sep 11 2019, 11:36 AM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/243/ for more details.

Harbormaster completed remote builds in B7760: Diff 6674.Sep 11 2019, 11:36 AM
ardumont accepted this revision.Sep 11 2019, 11:45 AM
This revision is now accepted and ready to land.Sep 11 2019, 11:45 AM
vlorentz updated this revision to Diff 6675.Sep 11 2019, 11:45 AM

no more need for raw string

This revision was landed with ongoing or failed builds.Sep 11 2019, 11:45 AM
Closed by commit rDJNL6738d448de69: Convert 'transplant_source' extra header to bytehdex. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B7761: Diff 6675!Sep 11 2019, 11:46 AM
swh-public-ci added a comment.Sep 11 2019, 11:46 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/244/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/244/console

Revision Contents
Changeset List

PathSize
swh/
journal/
27 lines

Diff 6676

View Options

swh/journal/replay.py

Loading...
About · Developer information · Legal