Paths

Table of Contentst

Differential D1969

Remove all API endpoints using an origin id.
ClosedPublic
Actions

Authored by vlorentz on Sep 6 2019, 4:44 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDWAPPSb74602b9a54a: Remove all API endpoints using an origin id.

Summary

They were already deprecated.

This will allow simplifying code in swh.storage.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 6 2019, 4:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 6 2019, 4:44 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/720/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/324/ for more details.

Harbormaster completed remote builds in B7718: Diff 6637.Sep 6 2019, 4:54 PM

Looks good to me. Let's get rid of these endpoints using these origin ids.

This revision is now accepted and ready to land.Sep 9 2019, 10:54 AM

For your information, I extracted all requests to swh-web in production containing /origin/ in their urls for the last 1 year (using the following Python script P522): 141892 requests were found.

As the associated elasticsearch index does not handle regexp query properly, I filtered the urls based on origin ids using grep ($ cat swh-web-origin-requests | grep -E /origin/[0-9]+)

All requests using origin ids for the last 1 year (aka today minus 1 year range) can be found here: P523 (for a total of 852 requests)

Almost all found requests consists querying an internal browse endpoint that has been removed since (rDWAPPS4762da3d332114f97bbebd86941d43a236929537).
This endpoint was called when performing an origin search through the Web UI.

Otherwise, only 18 requests to Web API endpoints using origin ids have been issued.

So removing the endpoints using origin ids seems pretty safe, considering they are not really used.

rebase

This revision was landed with ongoing or failed builds.Sep 10 2019, 11:57 AM

Closed by commit rDWAPPSb74602b9a54a: Remove all API endpoints using an origin id. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B7743: Diff 6660!Sep 10 2019, 11:57 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/721/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/721/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/325/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/325/console

vlorentz mentioned this in T1892: Cassandra as a storage backend.Oct 10 2019, 11:59 AM

vlorentz mentioned this in T2158: Properly deal with removed endpoints.Dec 17 2019, 5:02 PM

Revision Contents
Changeset List

Path

Size

2 lines

swh/

web/

api/

views/

123 lines

221 lines

common/

21 lines

tests/

api/

views/

234 lines

test_revision.py

273 lines

common/

test_service.py

54 lines

10 lines

12 lines

2 lines

Diff 6661

pytest.ini

Loading...

swh/web/api/views/origin.py

Loading...

swh/web/api/views/revision.py

Loading...

swh/web/common/service.py

Loading...

swh/web/tests/api/views/test_origin.py

Loading...

swh/web/tests/api/views/test_revision.py

Loading...

swh/web/tests/common/test_service.py

Loading...

swh/web/tests/strategies.py

Loading...

swh/web/tests/testcase.py

Loading...

tox.ini

Loading...