Page MenuHomeSoftware Heritage

core: Deal transparently with no 'visit_type' attribute in loaders
AbandonedPublic

Authored by ardumont on Wed, Sep 4, 11:31 AM.

Details

Reviewers
vlorentz
douardda
Group Reviewers
Reviewers
Summary

Currently, the current code fails multiple loaders (not exhaustive):

This is a transition and this should be removed when we are done with the
migration.

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7632
Build 10941: tox-on-jenkinsJenkins
Build 10940: arc lint + arc unit

Event Timeline

ardumont created this revision.Wed, Sep 4, 11:31 AM

See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/156/console

Currently working on that.
The new validations are currently failing (on the tests data) now that the issue is no longer with visit_type... yeah (i guess ;)

I thought I migrated all loaders. This diff will only sweep missing ones under the rug.

vlorentz requested changes to this revision.Wed, Sep 4, 11:43 AM
This revision now requires changes to proceed.Wed, Sep 4, 11:43 AM

I thought I migrated all loaders. This diff will only sweep missing ones under the rug.

I just check the loader-npm (for instance) and i see its attribute set to 'npm' indeed.

I'll do update the loader-deposit and the loader-dir (which are the current ones not migrated as far as the ci goes).

I fear the validation issue from this build is still relevant though.

I'm already on it :)

ardumont abandoned this revision.Wed, Sep 4, 11:53 AM

I'm already on it :)

ack, thx.

I fear the validation issue from this build is still relevant though.

ci agrees [1]
checking this out.

[1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/354/console