Page MenuHomeSoftware Heritage
Differential D1945

core: Deal transparently with no 'visit_type' attribute in loaders
AbandonedPublic
Actions

Authored by ardumont on Sep 4 2019, 11:31 AM.

Details

Reviewers
vlorentz
douardda
Group Reviewers
Reviewers
Summary

Currently, the current code fails multiple loaders (not exhaustive):

This is a transition and this should be removed when we are done with the
migration.

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7632
Build 10941: tox-on-jenkinsJenkins
Build 10940: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 4 2019, 11:31 AM
swh-public-ci added a comment.Sep 4 2019, 11:32 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/156/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/156/console

Harbormaster failed remote builds in B7632: Diff 6557!Sep 4 2019, 11:32 AM
ardumont added a comment.Sep 4 2019, 11:38 AM

See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/156/console

Currently working on that.
The new validations are currently failing (on the tests data) now that the issue is no longer with visit_type... yeah (i guess ;)

vlorentz added a comment.Sep 4 2019, 11:43 AM

I thought I migrated all loaders. This diff will only sweep missing ones under the rug.

vlorentz requested changes to this revision.Sep 4 2019, 11:43 AM
This revision now requires changes to proceed.Sep 4 2019, 11:43 AM
ardumont added a comment.Sep 4 2019, 11:48 AM

I thought I migrated all loaders. This diff will only sweep missing ones under the rug.

I just check the loader-npm (for instance) and i see its attribute set to 'npm' indeed.

I'll do update the loader-deposit and the loader-dir (which are the current ones not migrated as far as the ci goes).

I fear the validation issue from this build is still relevant though.

vlorentz added a comment.Sep 4 2019, 11:51 AM

I'm already on it :)

vlorentz mentioned this in D1946: Add missing visit_type attribute..Sep 4 2019, 11:51 AM
vlorentz mentioned this in D1948: Add missing visit_type attribute..
ardumont abandoned this revision.Sep 4 2019, 11:53 AM
ardumont added a comment.Sep 4 2019, 12:01 PM

I'm already on it :)

ack, thx.

I fear the validation issue from this build is still relevant though.

ci agrees [1]
checking this out.

[1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/354/console

vlorentz mentioned this in D1951: Fix validation errors in test..Sep 4 2019, 12:16 PM
vlorentz mentioned this in D1952: Add missing fields in test data..Sep 4 2019, 2:33 PM

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
6 lines

Diff 6557

View Options

swh/loader/core/loader.py

Loading...
About · Developer information · Legal