Page MenuHomeSoftware Heritage
Differential D1938

Refactor various cypress tests
ClosedPublic
Actions

Authored by kalpitk on Sep 2 2019, 6:14 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS87ac8daa0cdf: Refactor various cypress tests
Summary
  • Improve performance
  • Improve readability
  • remove unrequired code

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kalpitk created this revision.Sep 2 2019, 6:14 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 2 2019, 6:14 PM
swh-public-ci added a comment.Sep 2 2019, 6:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/712/ for more details.

swh-public-ci added a comment.Sep 2 2019, 6:27 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/316/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/316/console

Harbormaster failed remote builds in B7591: Diff 6524!Sep 2 2019, 6:27 PM
anlambert accepted this revision.Sep 3 2019, 5:54 PM
anlambert added a subscriber: anlambert.

Looks good to me, you can rebase and land it. You should also add the following Related T1768 in your commit message.

This revision is now accepted and ready to land.Sep 3 2019, 5:54 PM
kalpitk updated this revision to Diff 6568.Sep 4 2019, 1:03 PM
  • rebase
swh-public-ci added a comment.Sep 4 2019, 1:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/718/ for more details.

swh-public-ci added a comment.Sep 4 2019, 1:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/322/ for more details.

Harbormaster completed remote builds in B7643: Diff 6568.Sep 4 2019, 1:14 PM
Closed by commit rDWAPPS87ac8daa0cdf: Refactor various cypress tests (authored by kalpitk). · Explain WhySep 4 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cypress/
integration/
4 lines
5 lines
2 lines
2 lines
2 lines
48 lines

Diff 6597

View Options

cypress/integration/back-to-top.spec.js

Loading...
View Options

cypress/integration/code-highlighting.spec.js

Loading...
View Options

cypress/integration/directory.spec.js

Loading...
View Options

cypress/integration/errors.spec.js

Loading...
View Options

cypress/integration/layout.spec.js

Loading...
View Options

cypress/integration/sidebar.spec.js

Loading...
About · Developer information · Legal