Page MenuHomeSoftware Heritage
Differential D1916

README.md: Update requirements and document how to run the tests
ClosedPublic
Actions

Authored by anlambert on Aug 26 2019, 5:13 PM.

Details

Reviewers
vlorentz
Commits
rDWAPPS6f2275ca41e9: README.md: Update requirements and document how to run the tests
Summary

The details on how to run the backend and frontend tests of swh-web were
missing in the README. So add a section documenting the corresponding make
targets to easily run the those tests.

Depends on D1915

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 26 2019, 5:13 PM
swh-public-ci added a comment.Aug 26 2019, 5:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/702/ for more details.

swh-public-ci added a comment.Aug 26 2019, 5:31 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/306/ for more details.

Harbormaster completed remote builds in B7464: Diff 6425.Aug 26 2019, 5:31 PM
vlorentz accepted this revision.Aug 28 2019, 10:37 AM

I think it would be good to add fast in the name of targets that aren't full, so it's more obvious they don't run all the tests.

README.md
35–47

This should be a pip command using the requirement files, or it will get out of date

This revision is now accepted and ready to land.Aug 28 2019, 10:37 AM
anlambert added a comment.Aug 28 2019, 10:51 AM

I think it would be good to add fast in the name of targets that aren't full, so it's more obvious they don't run all the tests

I prefer to leave them like that to keep their name short. Plus, those make targets will be replaced by a proper Python CLI soon.

README.md
35–47

Ack, I will replace those lists by a link to the requirement files

vlorentz added a comment.Aug 28 2019, 10:55 AM
In D1916#44378, @anlambert wrote:

I prefer to leave them like that to keep their name short.

Shouldn't be an issue with autocomplete

anlambert updated this revision to Diff 6436.Aug 28 2019, 11:00 AM

Update: Rebase and replace requirement lists by links to requirement files

swh-public-ci added a comment.Aug 28 2019, 11:04 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/707/ for more details.

vlorentz added inline comments.Aug 28 2019, 11:09 AM
README.md
35–47

It could help to mention they can be installed with pip -r requirements.txt

swh-public-ci added a comment.Aug 28 2019, 11:11 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/311/ for more details.

Harbormaster completed remote builds in B7481: Diff 6436.Aug 28 2019, 11:11 AM
anlambert updated this revision to Diff 6437.Aug 28 2019, 11:29 AM

Update: rebase and add pip command invocation for installing depedencies

swh-public-ci added a comment.Aug 28 2019, 11:34 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/708/ for more details.

swh-public-ci added a comment.Aug 28 2019, 11:41 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/312/ for more details.

Harbormaster completed remote builds in B7483: Diff 6437.Aug 28 2019, 11:41 AM
Closed by commit rDWAPPS6f2275ca41e9: README.md: Update requirements and document how to run the tests (authored by anlambert). · Explain WhyAug 28 2019, 11:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
51 lines

Diff 6438

View Options

README.md

Loading...
About · Developer information · Legal