Page MenuHomeSoftware Heritage
Differential D1915

cypress: Skip tests marked as slow by default
ClosedPublic
Actions

Authored by anlambert on Aug 26 2019, 4:26 PM.

Details

Reviewers
vlorentz
Summary

Some cypress tests can take a long time to execute while not significantly
improving overall code coverage (e.g. language highlighting tests).

So add a way to declare a tests suite to be slow to execute and skip it
by default (notably to speedup CI jobs). In order to execute it back,
the CYPRESS_SKIP_SLOW_TESTS environment variable must be set to a value
different from 1.

Two new make targets have been added in order to execute all tests even
the slow ones:

  • test-frontend-all
  • test-frontend-all-ui

Diff Detail

Repository
rDWAPPS Web applications
Branch
speedup-cypress-tests
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7463
Build 10648: Cypress tests for swh-web diffsJenkins
Build 10647: tox-on-jenkinsJenkins
Build 10646: arc lint + arc unit

Event Timeline

anlambert created this revision.Aug 26 2019, 4:26 PM
swh-public-ci added a comment.Aug 26 2019, 4:31 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/700/ for more details.

swh-public-ci added a comment.Aug 26 2019, 4:37 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/304/ for more details.

Harbormaster completed remote builds in B7462: Diff 6423.Aug 26 2019, 4:37 PM
anlambert updated this revision to Diff 6424.EditedAug 26 2019, 5:09 PM

Update: rename some new make targets for more consistency with the previously defined ones

anlambert added a child revision: D1916: README.md: Update requirements and document how to run the tests.Aug 26 2019, 5:13 PM
swh-public-ci added a comment.Aug 26 2019, 5:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/701/ for more details.

swh-public-ci added a comment.Aug 26 2019, 5:20 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/305/ for more details.

Harbormaster completed remote builds in B7463: Diff 6424.Aug 26 2019, 5:20 PM
vlorentz requested changes to this revision.Aug 27 2019, 10:13 AM

Doing exports in some target that get used by another target sounds like a bad idea for readability.

If the intent is to avoid repeating the same command, write the command in a shell script and run the shell script in each makefile target

This revision now requires changes to proceed.Aug 27 2019, 10:13 AM
vlorentz added a comment.Aug 27 2019, 10:15 AM

And, are you sure that CYPRESS_SKIP_SLOW_TESTS=1 results in Cypress.env('SKIP_SLOW_TESTS') === 1? I would assume it's parsed as "1", not 1.

anlambert added a comment.Aug 27 2019, 10:28 AM

Doing exports in some target that get used by another target sounds like a bad idea for readability.

Seems pretty readable to me.

If the intent is to avoid repeating the same command, write the command in a shell script and run the shell script in each makefile target

Honestly, I do not want to add a shell script to wrap a single command and prefer to keep that in the Makefile

And, are you sure that CYPRESS_SKIP_SLOW_TESTS=1 results in Cypress.env('SKIP_SLOW_TESTS') === 1? I would assume it's parsed as "1", not 1

Yes, I tested it multiple times yesterday. It works as expected.

vlorentz added a comment.Aug 27 2019, 10:32 AM

Seems pretty readable to me.

Even before this change I get lost whenever I want to run swh-web

Honestly, I do not want to add a shell script to wrap a single command and prefer to keep that in the Makefile

There are five commands in test-frontend-cmd, and test-frontend-ui-cmd embeds a bash script that runs seven commands

anlambert added a comment.EditedAug 27 2019, 10:58 AM

T1972 created to implement CLI for easily running and testing swh-web

vlorentz accepted this revision.Aug 27 2019, 11:20 AM
This revision is now accepted and ready to land.Aug 27 2019, 11:20 AM
anlambert closed this revision.Aug 27 2019, 11:25 AM

I forgot to rebase, landed in c66798e1dcd.

Revision Contents
Changeset List

PathSize
19 lines
3 lines
cypress/
integration/
4 lines
utils/
2 lines

Diff 6424

View Options

Makefile.local

Loading...
View Options

cypress.json

Loading...
View Options

cypress/integration/content-rendering.spec.js

Loading...
View Options

cypress/utils/index.js

Loading...
About · Developer information · Legal