Differential D1881

Update origin_url/from_revision/metadata_tsvector when conflict_update=True.
ClosedPublic
Actions

Authored by vlorentz on Aug 21 2019, 3:12 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDCIDX128201f070f5: Update origin_url/from_revision/metadata_tsvector when conflict_update=True.

Summary

This caused:

inconsistent data, because 'metadata' was updated while from_revision was not, when an origin has a new head revision
corrupted data, because metadata_tsvector did not match 'metadata
origin_url was not set for origins that were indexed before introducing the field

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 21 2019, 3:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 21 2019, 3:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/604/ for more details.

Harbormaster completed remote builds in B7355: Diff 6318.Aug 21 2019, 3:15 PM

ardumont accepted this revision.Aug 26 2019, 3:30 PM

This revision is now accepted and ready to land.Aug 26 2019, 3:30 PM

Closed by commit rDCIDX128201f070f5: Update origin_url/from_revision/metadata_tsvector when conflict_update=True. (authored by vlorentz). · Explain WhyAug 26 2019, 3:31 PM

This revision was automatically updated to reflect the committed changes.

Oops, forgot to mention we miss the migration script for that db changes ;)

Revision Contents
Changeset List

Path

Size

swh/

indexer/

sql/

40-swh-func.sql

5 lines

tests/

storage/

test_storage.py

15 lines

Diff 6417

swh/indexer/sql/40-swh-func.sql

Loading...

swh/indexer/tests/storage/test_storage.py

Loading...