Page MenuHomeSoftware Heritage

Benchmark: output raw datapoints in CSV log file
ClosedPublic

Authored by haltode on Aug 16 2019, 12:14 PM.

Diff Detail

Repository
rDGRPH Compressed graph representation
Branch
benchmark-log-raw-data
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7273
Build 10291: tox-on-jenkinsJenkins
Build 10290: arc lint + arc unit

Event Timeline

zack requested changes to this revision.Aug 16 2019, 1:57 PM
zack added inline comments.
java/server/src/main/java/org/softwareheritage/graph/benchmark/Benchmark.java
105

Before the main loop, please output a CSV line with the column names, in order to make the CSV self-explanatory (to some extent, at least).

112

Can you use ";" as separator? Even if numbers use "." as decimal separator it is less confusing to not have commas around in CSV that contain numbers.

This revision now requires changes to proceed.Aug 16 2019, 1:57 PM
java/server/src/main/java/org/softwareheritage/graph/benchmark/Benchmark.java
112

Oh, while at it, please make the CSV separator a constant or class attribute somewhere, rather then hard coding and duplicating it.

  • Add CSV header line
  • Use ; as a CSV separator
This revision is now accepted and ready to land.Aug 16 2019, 6:06 PM
This revision was landed with ongoing or failed builds.Aug 16 2019, 6:12 PM
This revision was automatically updated to reflect the committed changes.