Close T1952.
Details
Details
- Reviewers
zack seirl - Maniphest Tasks
- T1952: Log raw datapoint in graph benchmarks
- Commits
- rDGRPH30218b7dc68f: server: benchmark: output raw datapoints in CSV log file
Diff Detail
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/12/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/12/console
| java/server/src/main/java/org/softwareheritage/graph/benchmark/Benchmark.java | ||
|---|---|---|
| 104 | Before the main loop, please output a CSV line with the column names, in order to make the CSV self-explanatory (to some extent, at least). | |
| 105–135 | Can you use ";" as separator? Even if numbers use "." as decimal separator it is less confusing to not have commas around in CSV that contain numbers. | |
| java/server/src/main/java/org/softwareheritage/graph/benchmark/Benchmark.java | ||
|---|---|---|
| 105–135 | Oh, while at it, please make the CSV separator a constant or class attribute somewhere, rather then hard coding and duplicating it. | |
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/13/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/13/console