When escaping a value fails when running a copy_to, there's currently
no diagnostics output. This patch adds some more information as log messages.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDCORE0ca10c9b4b7b: Add logging when escaping data fails in BaseDb.copy_to
tox and tox in swh.storage with the code change
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/276/ for more details.
swh/core/db/__init__.py | ||
---|---|---|
189–195 | You may be able to do something equivalent with simpler code: except Exception: logger.exception( 'Could not escape value `%r` for column `%s`', value, k) raise |
swh/core/db/__init__.py | ||
---|---|---|
187 | This line can probably be moved outside the try. |