Differential D1872

Make copy_to raise exceptions from the writer thread.
ClosedPublic
Actions

Authored by vlorentz on Aug 20 2019, 4:06 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDCORE9c720a14d035: Make copy_to raise exceptions from the writer thread.

Summary

Otherwise exceptions are silently ignored, until the transaction finishes.
And when the transaction fails, the returned error message is unhelpful.

This commit makes copy_to return the actual error message.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 20 2019, 4:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2019, 4:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/277/ for more details.

Harbormaster completed remote builds in B7341: Diff 6304.Aug 20 2019, 4:07 PM

vlorentz mentioned this in D1865: Make content_add validate its input using swh-model..Aug 20 2019, 4:35 PM

vlorentz added a child revision: D1865: Make content_add validate its input using swh-model..Aug 20 2019, 5:26 PM

I'm guessing this needs a rebase since I pushed D1853.

This revision now requires changes to proceed.Aug 22 2019, 1:42 PM

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/278/ for more details.

Harbormaster completed remote builds in B7371: Diff 6334.Aug 22 2019, 1:51 PM

olasd accepted this revision.Aug 22 2019, 1:53 PM

This revision is now accepted and ready to land.Aug 22 2019, 1:53 PM

Closed by commit rDCORE9c720a14d035: Make copy_to raise exceptions from the writer thread. (authored by vlorentz). · Explain WhyAug 22 2019, 1:54 PM

This revision was automatically updated to reflect the committed changes.

vlorentz removed a child revision: D1865: Make content_add validate its input using swh-model..Aug 22 2019, 3:37 PM

Revision Contents
Changeset List

Path

Size

swh/

core/

db/

__init__.py

14 lines

tests/

test_db.py

8 lines

Diff 6336

View Options

swh/core/db/init.py

View Options

swh/core/db/tests/test_db.py

Make copy_to raise exceptions from the writer thread.ClosedPublicActions