I don't understand why it's there; it completely breaks
the S3 backend because it can't parse the XML anymore.
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDOBJS5b9a6e8454e9: Remove override of S3.namespace.
Diff Detail
- Repository
- rDOBJS Object storage
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/75/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/76/ for more details.
Yes, a comment about what that does would have been nice.
Probably other objstorage backends related (seaweedfs? @douardda would know, highlighting for later ;)
Can't we introspect the provider and if it's s3 we don't do it?
The seaweedfs objstorage backend does not use this code, it's in swh/objstorage/backends/seaweed.py.
The seaweedfs objstorage backend does not use this code, it's in swh/objstorage/backends/seaweed.py.
yes, well, i don't know which one. david worked on multiple ones.
So i don't know if that's needed anymore or not.
oh well, let's remove it and see then.
To be more specific, this code is only used for S3 and Swift, and I highly doubt @douardda tested against Swift (why did we even explicitly add support for Swift?)