Page MenuHomeSoftware Heritage

Remove override of S3.namespace.
ClosedPublic

Authored by vlorentz on Aug 7 2019, 1:59 PM.

Details

Summary

I don't understand why it's there; it completely breaks
the S3 backend because it can't parse the XML anymore.

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 7 2019, 1:59 PM

Yes, a comment about what that does would have been nice.

Probably other objstorage backends related (seaweedfs? @douardda would know, highlighting for later ;)

Can't we introspect the provider and if it's s3 we don't do it?

The seaweedfs objstorage backend does not use this code, it's in swh/objstorage/backends/seaweed.py.

ardumont accepted this revision.Aug 7 2019, 2:30 PM

The seaweedfs objstorage backend does not use this code, it's in swh/objstorage/backends/seaweed.py.

yes, well, i don't know which one. david worked on multiple ones.
So i don't know if that's needed anymore or not.

oh well, let's remove it and see then.

This revision is now accepted and ready to land.Aug 7 2019, 2:30 PM

To be more specific, this code is only used for S3 and Swift, and I highly doubt @douardda tested against Swift (why did we even explicitly add support for Swift?)

This revision was automatically updated to reflect the committed changes.