Page MenuHomeSoftware Heritage

replayer: ensure the 'type' field of the origin_visit exists
AbandonedPublic

Authored by douardda on Jul 31 2019, 3:39 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Summary

wether the kafka message is an 'old format' or not.

And extract most of test_*_origin_visit tests in a helper function

Depends on D1788

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 7082
Build 9984: tox-on-jenkinsJenkins
Build 9983: arc lint + arc unit

Event Timeline

douardda created this revision.Jul 31 2019, 3:39 PM
vlorentz requested changes to this revision.Aug 5 2019, 10:28 AM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/journal/replay.py
49

This looks like it's trying to hide a crash without solving the actual issue.

This revision now requires changes to proceed.Aug 5 2019, 10:28 AM
douardda abandoned this revision.Aug 28 2019, 2:08 PM

Not sure this is needed any more. The test part will be provided a a dedicated diff