Differential D1789

replayer: ensure the 'type' field of the origin_visit exists
AbandonedPublic
Actions

Authored by douardda on Jul 31 2019, 3:39 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Summary

wether the kafka message is an 'old format' or not.

And extract most of test_*_origin_visit tests in a helper function

Depends on D1788

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 7082
Build 9984: tox-on-jenkins	Jenkins
Build 9983: arc lint + arc unit

Event Timeline

douardda created this revision.Jul 31 2019, 3:39 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 31 2019, 3:39 PM

douardda added a child revision: D1790: replayer: make the replayer handle kafka message without 'metadata' field.Jul 31 2019, 3:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/207/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/207/console

Harbormaster failed remote builds in B7082: Diff 6042!Jul 31 2019, 3:43 PM

vlorentz requested changes to this revision.Aug 5 2019, 10:28 AM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/journal/replay.py
49	This looks like it's trying to hide a crash without solving the actual issue.

This revision now requires changes to proceed.Aug 5 2019, 10:28 AM

Not sure this is needed any more. The test part will be provided a a dedicated diff

Revision Contents
Changeset List

Path

Size

swh/

journal/

replay.py

5 lines

tests/

test_replay.py

90 lines

Diff 6042

View Options

swh/journal/replay.py