Implemented gnu loader using the base loader
Depends on D1744
Details
- Reviewers
nahimilega - Group Reviewers
Reviewers
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- gnu
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7016 Build 9874: tox-on-jenkins Jenkins Build 9873: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/126/ for more details.
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/137/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/137/console
swh/loader/gnu/tests/test_loader.py | ||
---|---|---|
44–82 | These hashes are not updated for gnu loader. I found the swh identify method. But I didn't understand what exactly these hashes represent. I mean that swh identify tool return only one hash whereas we have a list of hashes here. |
swh/loader/gnu/tests/test_loader.py | ||
---|---|---|
44–82 |
You need to have the correct hashes according to the archive's tree structure (raw file as content, directories for tree, etc...) you ingest.
That's a tad problematic since that's what the loader is all about ;)
Yes, because each hash represents the hash (sha1 or sha1_git, don't remember which) of the raw content of the files found in the tarballs.
Aren't you the author of this? (I don't understand the question ;') The names seems to be explicit enough. Indeed, reading back the documentation (persistent identifier and data model) would be a good hint (see below).
There is:
[1] https://docs.softwareheritage.org/devel/swh-model/persistent-identifiers.html#persistent-identifiers [2] https://docs.softwareheritage.org/devel/swh-model/data-model.html#data-model |
swh/loader/gnu/loader.py | ||
---|---|---|
15 | Here you should add these: CONFIG_BASE_FILENAME = 'loader/gnu' ADDITIONAL_CONFIG = { 'temp_directory': ('str', '/tmp/swh.loader.gnu/'), 'debug': ('bool', False) } in order to declare the config filename and some default config entries for the loader. | |
20 | ||
swh/loader/gnu/tasks.py | ||
12 | You need to use keyword arguments here: return GNULoader().load(name=name, origin_url=origin_url, tarballs=tarballs) |
swh/loader/gnu/loader.py | ||
---|---|---|
15 | This was present in base loader class itself, it would assign config filename and some default config entries on the bases of loader name. but after a discussion with @ardumont in IRC and via these comments(https://forge.softwareheritage.org/D1694?id=5884#inline-11570 ) it was removed.
What should I do? |