Page MenuHomeSoftware Heritage
Differential D1705

Add a pre-commit config file
ClosedPublic
Actions

Authored by douardda on Jul 9 2019, 4:47 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCORE0f4c2e4ff573: Add a pre-commit config file
Summary

and document it briefly in the README file.

This comes with a few checkers:

  • flake8
  • trailing-whitespace
  • check-json
  • check-yaml
  • codespell

see https://pre-commit.com/ for more details.

Related to T1881.

foldme

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 9 2019, 4:47 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 9 2019, 4:47 PM
Harbormaster failed remote builds in B6738: Diff 5716!Jul 9 2019, 4:50 PM
swh-public-ci added a comment.Jul 9 2019, 4:50 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/245/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/245/console

ardumont added a subscriber: ardumont.Jul 10 2019, 10:07 AM
ardumont added inline comments.
README.md
65

hack on

ardumont accepted this revision.Jul 10 2019, 10:08 AM
This revision is now accepted and ready to land.Jul 10 2019, 10:08 AM
douardda updated this revision to Diff 5723.Jul 10 2019, 10:26 AM

rebased

Depends on D1704

Harbormaster failed remote builds in B6745: Diff 5723!Jul 10 2019, 10:28 AM
swh-public-ci added a comment.Jul 10 2019, 10:28 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/250/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/250/console

douardda updated this revision to Diff 5728.Jul 10 2019, 10:39 AM

rebased

Harbormaster failed remote builds in B6750: Diff 5728!Jul 10 2019, 10:41 AM
swh-public-ci added a comment.Jul 10 2019, 10:41 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/254/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/254/console

douardda added a parent revision: D1704: README: add a very short development setup guide.Jul 10 2019, 10:42 AM
swh-public-ci added a comment.Jul 10 2019, 10:44 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/255/ for more details.

Harbormaster completed remote builds in B6750: Diff 5728.Jul 10 2019, 10:45 AM
Closed by commit rDCORE0f4c2e4ff573: Add a pre-commit config file (authored by douardda). · Explain WhyJul 10 2019, 10:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5730

View Options

.pre-commit-config.yaml

Loading...
View Options

README.md

Loading...
View Options

requirements-test.txt

Loading...
About · Developer information · Legal