Paths

Table of Contentst

Differential D1675

Make origin_visit_upsert take an origin dict instead of int.
ClosedPublic
Actions

Authored by vlorentz on Jul 2 2019, 4:53 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTOC89fc4a3b321d: Make origin_visit_upsert take an origin dict instead of int.
rDSTO89fc4a3b321d: Make origin_visit_upsert take an origin dict instead of int.

Summary

That's the sensible format, and the one we already use in the backfiller.

Diff Detail

Repository

rDSTO Storage manager

Branch

upsert-origin-dict

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6629
Build 9256: tox-on-jenkins	Jenkins
Build 9255: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 2 2019, 4:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 2 2019, 4:53 PM

vlorentz mentioned this in D1676: Make the in-memory storage use URLs instead of ids as its 'primary key' internally..Jul 2 2019, 4:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/533/ for more details.

Harbormaster completed remote builds in B6629: Diff 5620.Jul 2 2019, 5:07 PM

douardda added a subscriber: douardda.Jul 3 2019, 9:56 AM

douardda added inline comments.

swh/storage/in_memory.py
1284	why this deepcopy necessary? I mean at this point, `visits` is already a deepcopy of the given `visits` argument.
1284	there is behavior change here (no more ValueError raised), it could be documented in the commit message I guess.
swh/storage/storage.py
1295	same question a above.

restore the ValueError.

vlorentz marked an inline comment as done.Jul 3 2019, 10:11 AM

vlorentz added inline comments.

swh/storage/in_memory.py
1284	because the list of visits is re-used below, and it needs the `'id'`.

vlorentz added a child revision: D1676: Make the in-memory storage use URLs instead of ids as its 'primary key' internally..Jul 3 2019, 10:13 AM

fix docstring

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/535/ for more details.

Harbormaster completed remote builds in B6637: Diff 5629.Jul 3 2019, 10:21 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/536/ for more details.

Harbormaster completed remote builds in B6638: Diff 5630.Jul 3 2019, 10:31 AM

douardda accepted this revision.Jul 3 2019, 3:56 PM

This revision is now accepted and ready to land.Jul 3 2019, 3:56 PM

Closed by commit rDSTO89fc4a3b321d: Make origin_visit_upsert take an origin dict instead of int. (authored by vlorentz). · Explain WhyJul 3 2019, 3:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

12 lines

13 lines

tests/

test_storage.py

6 lines

Diff 5620

swh/storage/in_memory.py

Loading...

swh/storage/storage.py

Loading...

swh/storage/tests/test_storage.py

Loading...