Page MenuHomeSoftware Heritage

Make origin_visit_upsert take an origin dict instead of int.
ClosedPublic

Authored by vlorentz on Jul 2 2019, 4:53 PM.

Details

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda added inline comments.
swh/storage/in_memory.py
1284

there is behavior change here (no more ValueError raised), it could be documented in the commit message I guess.

1287

why this deepcopy necessary? I mean at this point, visits is already a deepcopy of the given visits argument.

swh/storage/storage.py
1295

same question a above.

vlorentz added inline comments.
swh/storage/in_memory.py
1287

because the list of visits is re-used below, and it needs the 'id'.

This revision is now accepted and ready to land.Jul 3 2019, 3:56 PM
This revision was automatically updated to reflect the committed changes.