Differential D1658

Revert "Reformat docstrings for max line length"
ClosedPublic
Actions

Authored by twitu on Jun 28 2019, 5:35 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDDEP4c4324788ae0: Revert "Reformat docstrings for max line length"

Summary

I have somehow managed to push the abandoned revision D1647 which I authored in reference to T1836.
This reverts commit 216d0f74d8c3eeebb5d37f4d7f02130771caf7c6.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

twitu created this revision.Jun 28 2019, 5:35 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 28 2019, 5:35 AM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/167/ for more details.

Harbormaster completed remote builds in B6539: Diff 5544.Jun 28 2019, 5:40 AM

To expand on this further, I think the pre-push hook scripts you have configured only work when using git in a terminal. I am using vs code and curiously, I used the gui to push changes. I believe the scripts are not able to check such a situation and I can commit changes without review. This is probably a security flaw, that should be considered seriously. @zack

ardumont mentioned this in T1856: Adapt contribution policy?.Jun 28 2019, 10:53 AM

vlorentz accepted this revision.Jun 28 2019, 11:38 AM

This revision is now accepted and ready to land.Jun 28 2019, 11:38 AM

Rebase from master

This revision was landed with ongoing or failed builds.Jun 28 2019, 3:04 PM

Closed by commit rDDEP4c4324788ae0: Revert "Reformat docstrings for max line length" (authored by twitu). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B6553: Diff 5553!Jun 28 2019, 3:04 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/168/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/168/console