Page MenuHomeSoftware Heritage

Revert "Reformat docstrings for max line length"
ClosedPublic

Authored by twitu on Jun 28 2019, 5:35 AM.

Details

Summary

I have somehow managed to push the abandoned revision D1647 which I authored in reference to T1836.
This reverts commit 216d0f74d8c3eeebb5d37f4d7f02130771caf7c6.

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6553
Build 9133: tox-on-jenkinsJenkins
Build 9132: arc lint + arc unit

Event Timeline

To expand on this further, I think the pre-push hook scripts you have configured only work when using git in a terminal. I am using vs code and curiously, I used the gui to push changes. I believe the scripts are not able to check such a situation and I can commit changes without review. This is probably a security flaw, that should be considered seriously. @zack

This revision is now accepted and ready to land.Jun 28 2019, 11:38 AM
This revision was landed with ongoing or failed builds.Jun 28 2019, 3:04 PM
This revision was automatically updated to reflect the committed changes.