Finish dropping the 'description' column.
ClosedPublic
Actions

Authored by vlorentz on Jun 26 2019, 2:36 PM.

Details

Reviewers

douardda
ardumont

Group Reviewers

Reviewers

Commits

rDLS52b1de87c50b: Finish dropping the 'description' column.

Summary

I missed some in aef7d5952e16a9e877b5a3846ff6aaac0725eb4e.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 26 2019, 2:36 PM

Have you tried starting the docker-dev then?

This revision is now accepted and ready to land.Jun 26 2019, 2:37 PM

Have you tried starting the docker-dev then?

Tests are not enough apparently so i'd settle with that check for now.

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/275/ for more details.

Harbormaster completed remote builds in B6502: Diff 5509.Jun 26 2019, 2:40 PM

I checked with docker, it indeed fixes the issue

nahimilega added a subscriber: nahimilega.Jun 26 2019, 2:46 PM

nahimilega added inline comments.

swh/lister/cran/lister.py
27–30	The only way to get some metadata and description related to a packages is using R build in api. If we remove description from here then we will not have any metadata related to package which could be used in loader.

rebase

Have you tried starting the docker-dev then?

Tests are not enough apparently so i'd settle with that check for now.

And starting listing a gitlab instance as that'd be also not enough.

This revision was landed with ongoing or failed builds.Jun 26 2019, 2:46 PM

Closed by commit rDLS52b1de87c50b: Finish dropping the 'description' column. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B6503: Diff 5510!Jun 26 2019, 2:47 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/276/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/276/console

vlorentz added inline comments.Jun 26 2019, 2:49 PM

swh/lister/cran/lister.py
27–30	What will this metadata be used for?

nahimilega added inline comments.Jun 26 2019, 2:52 PM

swh/lister/cran/lister.py
27–30	As in other loaders(like pypi) there the is metadata url wich the loader visits and collect some data related to the package like author name and description. Same here but instead of giving the link of metadata url, we directly give metadata(that is description) which could be used in loader in same way as author name or description is used in pypi loader

vlorentz added inline comments.Jun 26 2019, 2:53 PM

swh/lister/cran/lister.py
27–30	Oh, right. Could you make a diff to restore this behavior (and add a test so it does not accidentally get removed again)?

nahimilega added inline comments.Jun 26 2019, 2:56 PM

swh/lister/cran/lister.py
27–30	I will surely make a diff to restore it, but I am not sure about the test. I didn't understood how to make the test for this and of what type. Some example would be really helpful here

vlorentz added inline comments.Jun 26 2019, 2:59 PM

swh/lister/cran/lister.py
27–30	With assert_called_once_with: with unittest.mock.patch('swh.scheduler.<blahblah>.create_tasks') as mock_create_tasks: # call the lister here mock_create_tasks.assert_called_once_with(blah blah)