Page MenuHomeSoftware Heritage

Add direct journal writer to uffizi
ClosedPublic

Authored by olasd on Jun 18 2019, 3:12 PM.

Details

Summary

Close T1825.

Depends on D1599

Test Plan

sensible octocatalog-diff output on uffizi

Diff Detail

Repository
rSPSITE puppet-swh-site
Branch
production
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6327
Build 8763: arc lint + arc unit

Event Timeline

For the sake of missing configuration field (looked multiple times differently and nowhere to be found on my side).

data/hostname/uffizi.softwareheritage.org.yaml
26

I do not see those in the defaults.yaml.

For the brokers option, i see kafka::brokers.
The other i see only hard-coded prefix at other locations.

27

I think it's a a free form field.

I'm not entirely sure what this field should convey as information.

But as the module in the storage has been renamed to journal_writer.
Shan't we maybe rename it to swh.storage.journal_writer. to match it?
I know it's redundant in here but at runtime, not so much (probably heh ;)

site-modules/profile/manifests/swh/deploy/storage.pp
19

I did not know we could do that, so thanks for highlighting me ;)

This revision now requires changes to proceed.Jun 19 2019, 9:20 AM

Ho, i just saw a previous diff, i'll amend the description then and repass on it.

I have a question though in there but that's not blocking.

data/hostname/uffizi.softwareheritage.org.yaml
26

Nevermind, i just saw D1599

This revision is now accepted and ready to land.Jun 19 2019, 9:24 AM

Rebase; update client_id to match class hierarchy

This revision was automatically updated to reflect the committed changes.