Paths

Table of Contentst

Differential D1601

Add direct journal writer to uffizi
ClosedPublic
Actions

Authored by olasd on Jun 18 2019, 3:12 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1825: Deploy kafka direct journal_writer to main storage

Commits

rSPSITEe225060c2ff1: Add direct journal writer to uffizi

Summary

Close T1825.

Depends on D1599

Test Plan

sensible octocatalog-diff output on uffizi

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jun 18 2019, 3:12 PM

Harbormaster completed remote builds in B6287: Diff 5306.Jun 18 2019, 3:12 PM

For the sake of missing configuration field (looked multiple times differently and nowhere to be found on my side).

data/hostname/uffizi.softwareheritage.org.yaml
26	I do not see those in the `defaults.yaml`. For the brokers option, i see `kafka::brokers`. The other i see only hard-coded prefix at other locations.
27	I think it's a a free form field. I'm not entirely sure what this field should convey as information. But as the module in the storage has been renamed to journal_writer. Shan't we maybe rename it to `swh.storage.journal_writer.` to match it? I know it's redundant in here but at runtime, not so much (probably heh ;)
site-modules/profile/manifests/swh/deploy/storage.pp
19	I did not know we could do that, so thanks for highlighting me ;)

This revision now requires changes to proceed.Jun 19 2019, 9:20 AM

Ho, i just saw a previous diff, i'll amend the description then and repass on it.

ardumont edited the summary of this revision. (Show Details)Jun 19 2019, 9:21 AM

ardumont added a parent revision: D1599: Stop hardcoding journal brokers everywhere.

I have a question though in there but that's not blocking.

data/hostname/uffizi.softwareheritage.org.yaml
26	Nevermind, i just saw D1599

This revision is now accepted and ready to land.Jun 19 2019, 9:24 AM

Rebase; update client_id to match class hierarchy

Harbormaster completed remote builds in B6327: Diff 5344.Jun 19 2019, 12:25 PM

Closed by commit rSPSITEe225060c2ff1: Add direct journal writer to uffizi (authored by olasd). · Explain WhyJun 19 2019, 12:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

data/

hostname/

uffizi.softwareheritage.org.yaml

6 lines

site-modules/

profile/

manifests/

swh/

deploy/

8 lines

Diff 5346

data/hostname/uffizi.softwareheritage.org.yaml

Loading...

site-modules/profile/manifests/swh/deploy/storage.pp

Loading...