Page MenuHomeSoftware Heritage
Differential D1597

Use origin urls instead of origin ids (swh-loader-svn)
ClosedPublic
Actions

Authored by vlorentz on Jun 18 2019, 2:31 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDSVNf915d6027af0: Use origin urls instead of origin ids.
Summary

As a side-effect, start using snapshot_get_all_branches, although it's probably
pointless in a *subversion* loader.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 18 2019, 2:31 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 18 2019, 2:31 PM
vlorentz mentioned this in T1816: Make all clients of swh-storage use origin URL as identifier and use visit types instead of origin types.Jun 18 2019, 2:32 PM
swh-public-ci added a comment.Jun 18 2019, 2:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/36/ for more details.

Harbormaster completed remote builds in B6280: Diff 5301.Jun 18 2019, 2:34 PM
vlorentz retitled this revision from Use origin urls instead of origin ids. to Use origin urls instead of origin ids (swh-loader-svn).Jun 18 2019, 2:50 PM
ardumont accepted this revision.Jun 18 2019, 3:09 PM
ardumont added a subscriber: ardumont.

Sounds good.

Did you rework the loader-core already?

swh/loader/svn/loader.py
146

(str)

beware, it happens also in other comments ;)

This revision is now accepted and ready to land.Jun 18 2019, 3:09 PM
vlorentz updated this revision to Diff 5307.Jun 18 2019, 3:13 PM

type

This revision was landed with ongoing or failed builds.Jun 18 2019, 3:14 PM
Closed by commit rDLDSVNf915d6027af0: Use origin urls instead of origin ids. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a comment.Jun 18 2019, 3:14 PM
In D1597#36258, @ardumont wrote:

Did you rework the loader-core already?

No, it will come last, because it sets a self.origin_id, which is used by many loaders, so I need to drop it from the loaders first.

Harbormaster failed remote builds in B6288: Diff 5307!Jun 18 2019, 3:15 PM
swh-public-ci added a comment.Jun 18 2019, 3:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/37/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/37/console

Revision Contents
Changeset List

PathSize
swh/
loader/
svn/
49 lines
8 lines

Diff 5308

View Options

swh/loader/svn/loader.py

Loading...
View Options

swh/loader/svn/svn.py

Loading...
About · Developer information · Legal