Page MenuHomeSoftware Heritage

Use origin urls instead of origin ids (swh-loader-svn)
ClosedPublic

Authored by vlorentz on Jun 18 2019, 2:31 PM.

Details

Summary

As a side-effect, start using snapshot_get_all_branches, although it's probably
pointless in a *subversion* loader.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
origin-urls
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6288
Build 8702: tox-on-jenkinsJenkins
Build 8701: arc lint + arc unit

Event Timeline

vlorentz retitled this revision from Use origin urls instead of origin ids. to Use origin urls instead of origin ids (swh-loader-svn).Jun 18 2019, 2:50 PM
ardumont added a subscriber: ardumont.

Sounds good.

Did you rework the loader-core already?

swh/loader/svn/loader.py
146

(str)

beware, it happens also in other comments ;)

This revision is now accepted and ready to land.Jun 18 2019, 3:09 PM
This revision was landed with ongoing or failed builds.Jun 18 2019, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Did you rework the loader-core already?

No, it will come last, because it sets a self.origin_id, which is used by many loaders, so I need to drop it from the loaders first.