Page MenuHomeSoftware Heritage

Add comments to few columns in dbversion, task and task_run
ClosedPublic

Authored by twitu on Jun 15 2019, 5:17 PM.

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

twitu created this revision.Jun 15 2019, 5:17 PM
twitu added a comment.Jun 15 2019, 5:18 PM

in reference to T1527

twitu updated this revision to Diff 5261.Jun 15 2019, 7:16 PM
  • Change double quoted comments to single quoted comments
twitu updated this revision to Diff 5262.Jun 15 2019, 7:20 PM
  • Change double quoted comments to single quoted comments
ardumont retitled this revision from Added comments to few columns in dbversion, task and task_run to Add comments to few columns in dbversion, task and task_run.Jun 18 2019, 10:26 AM
twitu added a comment.Jun 18 2019, 1:52 PM

Does this diff require any other changes?

vlorentz added inline comments.
sql/updates/13.sql
7

not release, but deployment

swh/scheduler/sql/30-swh-schema.sql
10

not release, but deployment

14

Must be changed to 13.

88

All possible statuses should be listed

twitu updated this revision to Diff 5300.Jun 18 2019, 2:30 PM
  • Make changes as per review
twitu marked 4 inline comments as done.Jun 18 2019, 4:09 PM
zack requested changes to this revision.Jun 19 2019, 3:53 PM
zack added a subscriber: zack.

minor caseness issue

sql/updates/13.sql
6

SQL (uppercase)

swh/scheduler/sql/30-swh-schema.sql
9

SQL

This revision now requires changes to proceed.Jun 19 2019, 3:53 PM
twitu updated this revision to Diff 5375.Jun 19 2019, 5:06 PM
  • Added comments to few columns in dbversion, task and task_run
  • Made changes as per review
twitu marked 2 inline comments as done.Jun 19 2019, 5:06 PM
zack accepted this revision.Jun 19 2019, 5:56 PM
This revision is now accepted and ready to land.Jun 19 2019, 5:56 PM
twitu updated this revision to Diff 5377.Jun 19 2019, 6:14 PM

Add comments to few columns in dbversion, task and task_run

This revision was automatically updated to reflect the committed changes.