Page MenuHomeSoftware Heritage

Add comments to few columns in dbversion, task and task_run
ClosedPublic

Authored by twitu on Jun 15 2019, 5:17 PM.

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6361
Build 8822: tox-on-jenkinsJenkins
Build 8821: arc lint + arc unit

Event Timeline

  • Change double quoted comments to single quoted comments
  • Change double quoted comments to single quoted comments
ardumont retitled this revision from Added comments to few columns in dbversion, task and task_run to Add comments to few columns in dbversion, task and task_run.Jun 18 2019, 10:26 AM

Does this diff require any other changes?

vlorentz added inline comments.
sql/updates/13.sql
6

not release, but deployment

swh/scheduler/sql/30-swh-schema.sql
9

not release, but deployment

14

Must be changed to 13.

87

All possible statuses should be listed

  • Make changes as per review
zack requested changes to this revision.Jun 19 2019, 3:53 PM
zack added a subscriber: zack.

minor caseness issue

sql/updates/13.sql
5

SQL (uppercase)

swh/scheduler/sql/30-swh-schema.sql
8

SQL

This revision now requires changes to proceed.Jun 19 2019, 3:53 PM
  • Added comments to few columns in dbversion, task and task_run
  • Made changes as per review
This revision is now accepted and ready to land.Jun 19 2019, 5:56 PM

Add comments to few columns in dbversion, task and task_run

This revision was automatically updated to reflect the committed changes.