Differential D1590

Add comments to few columns in dbversion, task and task_run
ClosedPublic
Actions

Authored by twitu on Jun 15 2019, 5:17 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSCH09e724573495: Added comments to few columns in dbversion, task and task_run

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6361
Build 8822: tox-on-jenkins	Jenkins
Build 8821: arc lint + arc unit

Event Timeline

twitu created this revision.Jun 15 2019, 5:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 15 2019, 5:17 PM

in reference to T1527

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/269/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/269/console

Harbormaster failed remote builds in B6235: Diff 5259!Jun 15 2019, 5:22 PM

Change double quoted comments to single quoted comments

Change double quoted comments to single quoted comments

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/271/ for more details.

Harbormaster completed remote builds in B6237: Diff 5261.Jun 15 2019, 7:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/272/ for more details.

Harbormaster completed remote builds in B6238: Diff 5262.Jun 15 2019, 7:32 PM

ardumont retitled this revision from Added comments to few columns in dbversion, task and task_run to Add comments to few columns in dbversion, task and task_run.Jun 18 2019, 10:26 AM

Does this diff require any other changes?

vlorentz added a subscriber: vlorentz.Jun 18 2019, 1:59 PM

vlorentz added inline comments.

sql/updates/13.sql
6	not release, but deployment
swh/scheduler/sql/30-swh-schema.sql
9	not release, but deployment
14	Must be changed to 13.
87	All possible statuses should be listed

Make changes as per review

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/273/ for more details.

Harbormaster completed remote builds in B6279: Diff 5300.Jun 18 2019, 2:34 PM

twitu marked 4 inline comments as done.Jun 18 2019, 4:09 PM

minor caseness issue

sql/updates/13.sql
5	SQL (uppercase)
swh/scheduler/sql/30-swh-schema.sql
8	SQL

This revision now requires changes to proceed.Jun 19 2019, 3:53 PM

Added comments to few columns in dbversion, task and task_run
Made changes as per review

twitu marked 2 inline comments as done.Jun 19 2019, 5:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/274/ for more details.

Harbormaster completed remote builds in B6358: Diff 5375.Jun 19 2019, 5:11 PM

zack accepted this revision.Jun 19 2019, 5:56 PM

This revision is now accepted and ready to land.Jun 19 2019, 5:56 PM

Add comments to few columns in dbversion, task and task_run

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/275/ for more details.

Harbormaster completed remote builds in B6361: Diff 5377.Jun 19 2019, 6:18 PM

Closed by commit rDSCH09e724573495: Added comments to few columns in dbversion, task and task_run (authored by twitu). · Explain WhyJun 19 2019, 6:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sql/

updates/

19 lines

swh/

scheduler/

sql/

30-swh-schema.sql

13 lines

Diff 5377

sql/updates/13.sql

Loading...

swh/scheduler/sql/30-swh-schema.sql

Loading...