Page MenuHomeSoftware Heritage
Differential D1580

Actually run the remote-pg-storage tests on a remote-pg.
ClosedPublic
Actions

Authored by vlorentz on Jun 13 2019, 4:28 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDSTOCc541224ed81e: Actually run the remote-pg-storage tests on a remote-pg.
rDSTOc541224ed81e: Actually run the remote-pg-storage tests on a remote-pg.
Summary

They were run on a local pg instead of via the HTTP API.

I don't understand why...

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 13 2019, 4:28 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 13 2019, 4:28 PM
swh-public-ci added a comment.Jun 13 2019, 4:35 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/481/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/481/console

Harbormaster failed remote builds in B6202: Diff 5228!Jun 13 2019, 4:35 PM
douardda accepted this revision.Jun 14 2019, 10:47 AM
douardda added a subscriber: douardda.

LGTM.
Now. what you do not understand "I don't understand why..." Is it "why the code does not behaves how it was intended to?" or "why the code was written so it actually uses a local storage?"

swh/storage/tests/test_api_client.py
59

This was done like this before this diff, but I don't really understand why we need to keep a ref on app as a member of the instance...

This revision is now accepted and ready to land.Jun 14 2019, 10:47 AM
vlorentz added a comment.Jun 14 2019, 11:00 AM
In D1580#35689, @douardda wrote:

Is it "why the code does not behaves how it was intended to?"

This one. The line self.storage = RemoteStorage(self.url()) was not run.

vlorentz updated this revision to Diff 5270.Jun 17 2019, 10:40 AM

rebase

swh-public-ci added a comment.Jun 17 2019, 10:52 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/495/ for more details.

Harbormaster completed remote builds in B6247: Diff 5270.Jun 17 2019, 10:52 AM
Closed by commit rDSTOc541224ed81e: Actually run the remote-pg-storage tests on a remote-pg. (authored by vlorentz). · Explain WhyJun 17 2019, 10:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
tests/
24 lines

Diff 5271

View Options

swh/storage/tests/test_api_client.py

Loading...
About · Developer information · Legal