Page MenuHomeSoftware Heritage

Fix key names in the in-mem impl of metadata_provider_{get,add}
ClosedPublic

Authored by vlorentz on Jun 5 2019, 1:35 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
test-metadata_provider_add
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6255
Build 8651: tox-on-jenkinsJenkins
Build 8650: arc lint + arc unit

Event Timeline

douardda added a subscriber: douardda.
douardda added inline comments.
swh/storage/tests/test_storage.py
3572

why not call it with **provider?

This revision is now accepted and ready to land.Jun 12 2019, 12:26 PM
swh/storage/tests/test_storage.py
3572

Because the argument names are provider_name, provider_type, and provider_url. I plan on changing that when D1509 is accepted.

vlorentz retitled this revision from Add a test for metadata_provider_add/get. to Fix key names in the in-mem impl of metadata_provider_{get,add}.
This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2019, 11:18 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.