Details

Reviewers

Group Reviewers

Commits

rDLSb81621274b78: lister: Unify credentials structure between listers

Summary

This becomes a dictionary of key <lister-name>, value a dict of key
<instance-name>, value list of dict username/password.

This allows configuration change to allow the following:

credentials:
  github:  # github lister
    github:  # has only one instance (so far)
    - username: some
      password: somekey
    - username: one
      password: onekey
    - ...
  gitlab:  # gitlab lister
    riseup:  # has many instances
    - username: someone
      password: ...
    - ...
    gitlab:
    - username: someone
      password: ...
    - ...

Related T1772

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5954
Build 8164: tox-on-jenkins	Jenkins
Build 8163: arc lint + arc unit

Event Timeline

ardumont created this revision.May 29 2019, 12:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 29 2019, 12:14 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/149/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/149/console

Harbormaster failed remote builds in B5951: Diff 5003!May 29 2019, 12:16 PM

ardumont planned changes to this revision.May 29 2019, 12:22 PM

ardumont edited the summary of this revision. (Show Details)May 29 2019, 12:28 PM

ardumont edited the test plan for this revision. (Show Details)

ardumont added a reviewer: douardda.

Improve docstrings and fix wrong data introspection

ardumont planned changes to this revision.May 29 2019, 12:35 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/150/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/150/console

Harbormaster failed remote builds in B5952: Diff 5004!May 29 2019, 12:37 PM

Add missing phabricator lister instance

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/151/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/151/console

Harbormaster failed remote builds in B5953: Diff 5005!May 29 2019, 1:31 PM

ardumont retitled this revision from lister: Unify credentials structure between listers to lister: Unify credentials configuration structure between listers.May 29 2019, 1:38 PM

Fix missing phabricator unit tests update

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/152/ for more details.

Harbormaster completed remote builds in B5954: Diff 5006.May 29 2019, 1:43 PM

douardda accepted this revision.May 29 2019, 1:51 PM

This revision is now accepted and ready to land.May 29 2019, 1:51 PM

Update docstrings
Add instance fallback behavior to parsing the forge url if instance not provided

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/153/ for more details.

Harbormaster completed remote builds in B5955: Diff 5007.May 29 2019, 2:03 PM

Closed by commit rDLSb81621274b78: lister: Unify credentials structure between listers (authored by ardumont). · Explain WhyMay 29 2019, 2:04 PM

This revision was automatically updated to reflect the committed changes.

ardumont mentioned this in T1772: Lister: Simplify production deployment for listers.May 29 2019, 2:30 PM

ardumont mentioned this in D1482: GNU Lister.May 30 2019, 3:49 PM