Add dbreplica CNAME
AbandonedPublic
Actions

Authored by ardumont on May 28 2019, 12:05 PM.

Details

Reviewers

ftigeot
olasd
zack

Group Reviewers

Reviewers

Summary

Related T1234

Test Plan

$ bin/octocatalog-diff ... pergamon
Found host pergamon.softwareheritage.org
*** Running octocatalog-diff on host pergamon.softwareheritage.org
diff origin/production/pergamon.softwareheritage.org current/pergamon.softwareheritage.org
*******************************************
  File[/etc/bind/keys/local-update] =>
   parameters =>
     content =>
      [36m@@ -2,4 +2,4 @@[0m
       key local-update {
       	algorithm hmac-sha256;
      [31m-	secret "redacted";[0m
      [32m+	secret "redacted";[0m
       };
*******************************************
  File[/etc/bind/rndc.key] =>
   parameters =>
     content =>
      [36m@@ -2,4 +2,4 @@[0m
       key rndc-key {
       	algorithm hmac-md5;
      [31m-	secret "redacted";[0m
      [32m+	secret "redacted";[0m
       };
*******************************************
[0;32;49m+ Resource_record[dbreplica/CNAME] =>[0m
[0;32;49m   parameters =>[0m
[0;32;49m[0;32;49m      "data": "somerset.internal.softwareheritage.org"[0m[0m
[0;32;49m[0;32;49m      "keyfile": "/etc/bind/keys/local-update"[0m[0m
[0;32;49m[0;32;49m      "record": "dbreplica.internal.softwareheritage.org"[0m[0m
[0;32;49m[0;32;49m      "type": "CNAME"[0m[0m
*******************************************
*** End octocatalog-diff on pergamon.softwareheritage.org

Diff Detail

Repository

rSPSITE puppet-swh-site

Branch

add_dbreplica_cname

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5957
Build 8168: arc lint + arc unit

Event Timeline

ardumont created this revision.May 28 2019, 12:05 PM

Harbormaster completed remote builds in B5943: Diff 4994.May 28 2019, 12:05 PM

ardumont edited the test plan for this revision. (Show Details)May 28 2019, 12:05 PM

ardumont added a project: Staff.

ardumont edited the test plan for this revision. (Show Details)

I'm not convinced this is such a good idea; this machine is way more than a "db replica" server (it only has one replica, most its databases are actually primary) and I don't think DNS provides the appropriate granularity level to record this information.

I think configuring pgbouncer to have transparent access to read-only/read-write databases would be more appropriate and flexible than doing dns hacks.

In D1516#34010, @olasd wrote:

I'm not convinced this is such a good idea; this machine is way more than a "db replica" server (it only has one replica, most its databases are actually primary) and I don't think DNS provides the appropriate granularity level to record this information.

Right, the machine does multiple things, but CNAMEs are not mutually exclusive.

I think configuring pgbouncer to have transparent access to read-only/read-write databases would be more appropriate and flexible than doing dns hacks.

Can we have both?

olasd mentioned this in T1234: Allow simple read-only connections to db from swh nodes.May 28 2019, 4:07 PM

Branch diff to another branch

Harbormaster completed remote builds in B5957: Diff 5009.May 29 2019, 2:23 PM

ardumont planned changes to this revision.May 29 2019, 2:50 PM

See T1234's amended description