There is more repetition, but it's easier to read and
'%timeit Revision.from_dict(d)' is 5 times faster.
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDMOD6ef1dc1cdd7c: Explicitely implement from_dict instead of using introspection magic.
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- from_dict-no-magic
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5663 Build 7733: tox-on-jenkins Jenkins Build 7732: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/72/ for more details.
Comment Actions
I agree it's easier to read, so LGTM (just a small refactoring and I'm ok with this)
swh/model/model.py | ||
---|---|---|
310 | should be the right time to rewrite this using a list comprehension IMHO |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/74/ for more details.