Differential D1456

Explicitely implement from_dict instead of using introspection magic.
ClosedPublic
Actions

Authored by vlorentz on May 9 2019, 4:30 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDMOD6ef1dc1cdd7c: Explicitely implement from_dict instead of using introspection magic.

Summary

There is more repetition, but it's easier to read and
'%timeit Revision.from_dict(d)' is 5 times faster.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 9 2019, 4:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 9 2019, 4:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/72/ for more details.

Harbormaster completed remote builds in B5655: Diff 4759.May 9 2019, 4:32 PM

I agree it's easier to read, so LGTM (just a small refactoring and I'm ok with this)

swh/model/model.py
310	should be the right time to rewrite this using a list comprehension IMHO

This revision now requires changes to proceed.May 10 2019, 10:23 AM

list comp

douardda accepted this revision.May 10 2019, 10:26 AM

This revision is now accepted and ready to land.May 10 2019, 10:26 AM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/74/ for more details.

Harbormaster completed remote builds in B5663: Diff 4767.May 10 2019, 10:27 AM

Closed by commit rDMOD6ef1dc1cdd7c: Explicitely implement from_dict instead of using introspection magic. (authored by vlorentz). · Explain WhyMay 10 2019, 10:40 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

model/

model.py

98 lines

Diff 4769

View Options

Explicitely implement from_dict instead of using introspection magic.ClosedPublicActions