Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/214/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/214/console

Instead of swh/core/X/tests/, you should put tests in swh/core/tests/X/ (where X is the sub-component), for uniformity with other repos (deposit/indexer/storage/web)

Build fails with:

_______________ ERROR collecting swh/core/db/tests/test_db.py _________________
swh/core/db/tests/test_db.py:14: in <module>
    from .db_testing import (
E   SystemError: Parent module '' not loaded, cannot perform relative import
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=

Wondering if we are not missing __init__.py files in the new subfolders created (db, api, server)?

In D1444#31944, @ardumont wrote:

Build fails with:

_______________ ERROR collecting swh/core/db/tests/test_db.py _________________
swh/core/db/tests/test_db.py:14: in <module>
    from .db_testing import (
E   SystemError: Parent module '' not loaded, cannot perform relative import
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=

Wondering if we are not missing __init__.py files in the new subfolders created (db, api, server)?

Indeed I forget to git add a few of those

In D1444#31943, @vlorentz wrote:

Instead of swh/core/X/tests/, you should put tests in swh/core/tests/X/ (where X is the sub-component), for uniformity with other repos (deposit/indexer/storage/web)

let me check that

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/216/ for more details.

In D1444#31990, @douardda wrote:

In D1444#31943, @vlorentz wrote:

Instead of swh/core/X/tests/, you should put tests in swh/core/tests/X/ (where X is the sub-component), for uniformity with other repos (deposit/indexer/storage/web)

let me check that

Actually it's not without a drawback: if I move these test dirs as proposed, I won't be able to easily execute basic swh.core tests alone.
With:

tests/
├── api
│   ├── __init__.py
│   ├── server_testing.py
│   ├── test_api.py
│   └── test_serializers.py
├── db
│   ├── conftest.py
│   ├── db_testing.py
│   ├── __init__.py
│   └── test_db.py
├── __init__.py
├── test_config.py
├── test_statsd.py
└── test_utils.py

I cannot easily write the testenv:py3-core tox section (and yes, I know the --ignore option for pytest). Which means I need to move 'core' tests (aka test_config.py, test_statsd.py and test_utils.py) in a sub directory, which I find quite clumsy.

To be honest, since we supply tests as part of the code (ie. tests are subpackages shipped with the code), I prefer the pattern:

packages/
├── tests/
├── subpackage1/
│   └── tests/
└── subpackage2
    └── tests/

than what we mainly use today. It keeps the tests close to the tested code and make a potential extraction/refactoring a bit easier. But meh/

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/223/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/223/console