Make sure that revision metadata is passed through from the caller
ClosedPublic
Actions

Authored by olasd on Apr 18 2019, 4:20 PM.

Details

Reviewers

moranegg
ardumont

Maniphest Tasks

T1676: Bug: the deposit metadata is not added to the revision while those are present

Commits

rDLDTARf338e4c16403: Make sure that revision metadata is passed through from the caller

Summary

The addition of original_artifact metadata was done at the expense of other
metadata sent by the caller, which breaks the metadata for deposits.

Close T1676.

Test Plan

tox with the new unit test

Diff Detail

Repository

rDLDTAR Tarball Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Apr 18 2019, 4:20 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/107/ for more details.

Harbormaster completed remote builds in B5500: Diff 4624.Apr 18 2019, 4:22 PM

ardumont accepted this revision.Apr 19 2019, 7:42 AM

This revision is now accepted and ready to land.Apr 19 2019, 7:42 AM

Closed by commit rDLDTARf338e4c16403: Make sure that revision metadata is passed through from the caller (authored by olasd). · Explain WhyApr 19 2019, 8:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

loader/

tar/

build.py

32 lines

loader.py

34 lines

tests/

test_loader.py

15 lines

Diff 4630

View Options

swh/loader/tar/build.py

View Options

swh/loader/tar/loader.py

View Options

swh/loader/tar/tests/test_loader.py

Make sure that revision metadata is passed through from the callerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4630

swh/loader/tar/build.py

swh/loader/tar/loader.py

swh/loader/tar/tests/test_loader.py

Make sure that revision metadata is passed through from the caller
ClosedPublic
Actions

Revision Contents
Changeset List