Differential D1422

deposit: Wrongly formatted xml should return a 400 bad request
ClosedPublic
Actions

Authored by ardumont on Apr 17 2019, 2:19 PM.

Tags

Subscribers

None

Details

Reviewers

moranegg
douardda

Group Reviewers

Commits

rDDEP3b19233c6d66: tests: Reformat some deposit tests
rDDEP793b0d18e453: deposit: Wrongly formatted xml should return a 400 bad request

Summary

Both for multipart deposit and only-metadata (atom) deposit.

This is a new kind of badly formatted which ended up in 500 internal
error (server side).

This also contains movments in test (which i did not change), i just
moved the xml data contextually to where it's used (clearer to read).

Related T1638

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Branch

deal-with-xml-parsing-error

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5488
Build 7449: tox-on-jenkins	Jenkins
Build 7448: arc lint + arc unit

Event Timeline

ardumont created this revision.Apr 17 2019, 2:19 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/121/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/121/console

Harbormaster failed remote builds in B5487: Diff 4615!Apr 17 2019, 2:20 PM

Fix typo and flake8 error

ardumont edited the summary of this revision. (Show Details)Apr 17 2019, 2:24 PM

ardumont added a project: SWORD deposit.

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/122/ for more details.

Harbormaster completed remote builds in B5488: Diff 4616.Apr 17 2019, 2:25 PM

Validating this but we have some changes to do on the added test to follow a more restrictive grammar.

swh/deposit/tests/api/test_deposit_atom.py
425	I need to find the real reference to external_id, because I don't know from which vocabulary it is. This is not a blocker for this diff.
swh/deposit/tests/api/test_deposit_multipart.py
412	We need to review the tests to follow a more restrictive grammar.

This revision is now accepted and ready to land.Apr 17 2019, 2:51 PM

Plug on master

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/124/ for more details.

Harbormaster completed remote builds in B5490: Diff 4618.Apr 17 2019, 3:32 PM

Closed by commit rDDEP793b0d18e453: deposit: Wrongly formatted xml should return a 400 bad request (authored by ardumont). · Explain WhyApr 17 2019, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

deposit/

api/

24 lines

15 lines

13 lines

tests/

api/

test_deposit_atom.py

233 lines

test_deposit_multipart.py

46 lines

Diff 4616

swh/deposit/api/common.py

Loading...

swh/deposit/errors.py

Loading...

swh/deposit/parsers.py

Loading...

swh/deposit/tests/api/test_deposit_atom.py

Loading...

swh/deposit/tests/api/test_deposit_multipart.py

Loading...