Page MenuHomeSoftware Heritage
Differential D1404

tasks: fix handling of unsupported promise.save() calls
ClosedPublic
Actions

Authored by douardda on Apr 11 2019, 11:06 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLSe5c355903323: tasks: fix handling of unsupported promise.save() calls
Summary

the exception can also be an AttributeError.

Also do not reraise this exception (in github/tasks.py). This promise
saving feature is used for tests.

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5329
Build 7224: tox-on-jenkinsJenkins
Build 7223: arc lint + arc unit

Event Timeline

douardda created this revision.Apr 11 2019, 11:06 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 11 2019, 11:06 AM
swh-public-ci added a comment.Apr 11 2019, 11:08 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/90/ for more details.

Harbormaster completed remote builds in B5329: Diff 4521.Apr 11 2019, 11:08 AM
vlorentz accepted this revision.Apr 11 2019, 11:10 AM
vlorentz added a subscriber: vlorentz.

That code (and the lines before) look very similar to each other.

This revision is now accepted and ready to land.Apr 11 2019, 11:10 AM
douardda added a comment.Apr 11 2019, 11:13 AM
In D1404#30533, @vlorentz wrote:

That code (and the lines before) look very similar to each other.

indeed! more refactoring in sight!

Closed by commit rDLSe5c355903323: tasks: fix handling of unsupported promise.save() calls (authored by douardda). · Explain WhyApr 11 2019, 11:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
lister/
bitbucket/
2 lines
github/
3 lines
gitlab/
2 lines

Diff 4521

View Options

swh/lister/bitbucket/tasks.py

Loading...
View Options

swh/lister/github/tasks.py

Loading...
View Options

swh/lister/gitlab/tasks.py

Loading...
About · Developer information · Legal