Differential D1390

Make the replayer commit after adding objects to the replica.
ClosedPublic
Actions

Authored by vlorentz on Apr 10 2019, 11:41 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T1628: replayer: non reliability when fetching items from kafka

Commits

rDJNL9c9ed315dbec: Make the replayer commit *after* adding objects to the replica.

Summary

Resolves T1628.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 10 2019, 11:41 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 10 2019, 11:41 AM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/139/ for more details.

Harbormaster completed remote builds in B5296: Diff 4486.Apr 10 2019, 11:43 AM

Now that we get the messages in packets, as a further step it would make sense to bundle insertions in the database.

This revision is now accepted and ready to land.Apr 10 2019, 1:19 PM

Closed by commit rDJNL9c9ed315dbec: Make the replayer commit *after* adding objects to the replica. (authored by vlorentz). · Explain WhyApr 10 2019, 1:22 PM

This revision was automatically updated to reflect the committed changes.

vlorentz mentioned this in D1395: Make the replayer insert objects in batches..Apr 10 2019, 1:42 PM

Revision Contents
Changeset List

Path

Size

swh/

journal/

replay.py

44 lines

tests/

test_write_replay.py

23 lines

Diff 4491

View Options

swh/journal/replay.py