Page MenuHomeSoftware Heritage

Make the replayer insert objects in batches.
ClosedPublic

Authored by vlorentz on Apr 10 2019, 1:42 PM.

Details

Summary

Follow-up on D1390.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 10 2019, 1:42 PM
olasd added a subscriber: olasd.Apr 10 2019, 3:04 PM
olasd added inline comments.
swh/journal/replay.py
77–82

Could we do the batch insertion (which should always succeed in prod) and only fall back to 1 by 1 insertion when a hash collision occurs (which will pretty much only happen when testing)?

vlorentz added inline comments.Apr 10 2019, 3:07 PM
swh/journal/replay.py
77–82

That was my initial idea, but I thought if would never pass your or david's review

77–82

s/if/it/

olasd accepted this revision.Apr 10 2019, 5:17 PM
This revision is now accepted and ready to land.Apr 10 2019, 5:17 PM
This revision was automatically updated to reflect the committed changes.