Differential D1395

Make the replayer insert objects in batches.
ClosedPublic
Actions

Authored by vlorentz on Apr 10 2019, 1:42 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDJNL730f4b911942: Make the replayer insert objects in batches.

Summary

Follow-up on D1390.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 10 2019, 1:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 10 2019, 1:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/140/ for more details.

Harbormaster completed remote builds in B5302: Diff 4492.Apr 10 2019, 1:45 PM

olasd added a subscriber: olasd.Apr 10 2019, 3:04 PM

olasd added inline comments.

swh/journal/replay.py
77–82	Could we do the batch insertion (which should always succeed in prod) and only fall back to 1 by 1 insertion when a hash collision occurs (which will pretty much only happen when testing)?

vlorentz added inline comments.Apr 10 2019, 3:07 PM

swh/journal/replay.py
77–82	That was my initial idea, but I thought if would never pass your or david's review
77–82	s/if/it/

olasd accepted this revision.Apr 10 2019, 5:17 PM

This revision is now accepted and ready to land.Apr 10 2019, 5:17 PM

Closed by commit rDJNL730f4b911942: Make the replayer insert objects in batches. (authored by vlorentz). · Explain WhyApr 11 2019, 9:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

41 lines

tests/

test_write_replay.py

63 lines

Diff 4514

swh/journal/replay.py

Loading...

swh/journal/tests/test_write_replay.py

Loading...