Paths

Table of Contentst

Differential D1384

Explicitely give Db connections back to the pool.
ClosedPublic
Actions

Authored by vlorentz on Apr 9 2019, 4:56 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDCORE1d9c0bf05c32: Explicitely give Db connections back to the pool.

Summary

So they gracefully release the connection on error instead
of relying on reference-counting to call the Db's __del__
(which does not happen in Hypothesis tests) because a ref
to it is kept via the traceback object.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

put_conn

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5246
Build 7097: tox-on-jenkins	Jenkins
Build 7096: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 9 2019, 4:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 9 2019, 4:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/201/ for more details.

Harbormaster completed remote builds in B5246: Diff 4438.Apr 9 2019, 4:58 PM

olasd accepted this revision.Apr 9 2019, 5:33 PM

olasd added a subscriber: olasd.

olasd added inline comments.

swh/core/db/common.py
51	Can we guard this with an `if hasattr(self, 'put_db')` to avoid making other users of this (indexer, archiver) insta-buggy?
84	Same comment

This revision is now accepted and ready to land.Apr 9 2019, 5:33 PM

vlorentz added inline comments.Apr 9 2019, 5:35 PM

swh/core/db/common.py
51	No, because I removed `BaseDb.__del__`, so it would leak connections in prod.

vlorentz mentioned this in D1385: Add method put_db, required by swh-core >= v0.0.59..Apr 9 2019, 5:39 PM

vlorentz mentioned this in D1386: Add method put_db, required by swh-core >= v0.0.59..

vlorentz mentioned this in D1387: Add method put_db, required by swh-core >= v0.0.59..Apr 9 2019, 5:42 PM

Closed by commit rDCORE1d9c0bf05c32: Explicitely give Db connections back to the pool. (authored by vlorentz). · Explain WhyApr 9 2019, 6:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

core/

db/

__init__.py

3 lines

common.py

19 lines

Diff 4438

View Options

swh/core/db/init.py

View Options

Explicitely give Db connections back to the pool.ClosedPublicActions